Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubs/Scopes Merge 12 - Replace IHub with IScopes in Spring 6 / Spring Boot 3 integrations #3309

Merged

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Apr 2, 2024

#skip-changelog

📜 Description

Follow up for #3297 changing Spring 6 / Spring Boot 3 integrations.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 86ac8bc

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 439.45 ms 521.61 ms 82.17 ms
Size 1.70 MiB 2.28 MiB 592.27 KiB

Previous results on branch: feat/hsm-12-replacements-in-spring-6-boot-3-integrations

Startup times

Revision Plain With Sentry Diff
4b65fe9 419.57 ms 487.65 ms 68.07 ms

App size

Revision Plain With Sentry Diff
4b65fe9 1.70 MiB 2.28 MiB 592.27 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on class Reactive in SentryProperties should refer to scopes.
Should we rename HubConfiguration in SentryAutoConfiguration?
Comment on class EnableSentry refer to Hub instead of Scopes.

Also, should we rename the SentryHubRegistrar and its methods?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename HubConfiguration in SentryAutoConfiguration?

@@ -116,7 +116,7 @@ static class HubConfiguration {
}

@Bean
public @NotNull IHub sentryHub(
public @NotNull IScopes sentryHub(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this method?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be renamed to SentryScopesRegistrar?

Base automatically changed from feat/hsm-11-replacements-in-spring-5-boot-2-integrations to 8.x.x April 16, 2024 14:43
@adinauer
Copy link
Member Author

We need to test whether renaming Spring beans and config classes breaks anything. Even then user code could break by renaming them.

@adinauer adinauer merged commit e11f8b1 into 8.x.x Apr 16, 2024
4 of 6 checks passed
@adinauer adinauer deleted the feat/hsm-12-replacements-in-spring-6-boot-3-integrations branch April 16, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants