-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hubs/Scopes Merge 12 - Replace IHub
with IScopes
in Spring 6 / Spring Boot 3 integrations
#3309
Hubs/Scopes Merge 12 - Replace IHub
with IScopes
in Spring 6 / Spring Boot 3 integrations
#3309
Conversation
|
Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on class Reactive
in SentryProperties
should refer to scopes
.
Should we rename HubConfiguration in SentryAutoConfiguration?
Comment on class EnableSentry refer to Hub instead of Scopes.
Also, should we rename the SentryHubRegistrar and its methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename HubConfiguration
in SentryAutoConfiguration
?
@@ -116,7 +116,7 @@ static class HubConfiguration { | |||
} | |||
|
|||
@Bean | |||
public @NotNull IHub sentryHub( | |||
public @NotNull IScopes sentryHub( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename this method?
...y-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/AbstractSentryWebFilter.java
Show resolved
Hide resolved
...y-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/AbstractSentryWebFilter.java
Show resolved
Hide resolved
...y-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/AbstractSentryWebFilter.java
Show resolved
Hide resolved
sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/ReactorUtils.java
Show resolved
Hide resolved
sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/ReactorUtils.java
Show resolved
Hide resolved
sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/ReactorUtils.java
Show resolved
Hide resolved
sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryScheduleHook.java
Show resolved
Hide resolved
sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryScheduleHook.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be renamed to SentryScopesRegistrar
?
We need to test whether renaming Spring beans and config classes breaks anything. Even then user code could break by renaming them. |
#skip-changelog
📜 Description
Follow up for #3297 changing Spring 6 / Spring Boot 3 integrations.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps