-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add start_type to app context #3379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushi
requested review from
adinauer,
romtsn and
stefanosiano
as code owners
April 22, 2024 09:58
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4e260b3 | 378.73 ms | 454.18 ms | 75.45 ms |
4bf95dd | 345.96 ms | 414.24 ms | 68.28 ms |
0bd723b | 395.44 ms | 472.66 ms | 77.22 ms |
7275aa8 | 422.39 ms | 456.94 ms | 34.55 ms |
baaf637 | 375.71 ms | 441.58 ms | 65.87 ms |
7eccfdb | 366.98 ms | 440.27 ms | 73.29 ms |
937879e | 417.64 ms | 550.45 ms | 132.81 ms |
9119d59 | 407.12 ms | 509.64 ms | 102.52 ms |
93a76ca | 378.48 ms | 451.78 ms | 73.30 ms |
93a76ca | 377.96 ms | 447.52 ms | 69.56 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4e260b3 | 1.72 MiB | 2.27 MiB | 554.95 KiB |
4bf95dd | 1.72 MiB | 2.29 MiB | 576.40 KiB |
0bd723b | 1.72 MiB | 2.29 MiB | 578.09 KiB |
7275aa8 | 1.70 MiB | 2.28 MiB | 590.71 KiB |
baaf637 | 1.72 MiB | 2.27 MiB | 558.42 KiB |
7eccfdb | 1.72 MiB | 2.27 MiB | 556.93 KiB |
937879e | 1.72 MiB | 2.27 MiB | 558.42 KiB |
9119d59 | 1.70 MiB | 2.27 MiB | 583.84 KiB |
93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
Previous results on branch: feat/app-context-start-type
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a70554c | 369.39 ms | 438.65 ms | 69.27 ms |
5b9b5ac | 375.58 ms | 458.57 ms | 82.99 ms |
97da736 | 390.06 ms | 465.79 ms | 75.73 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a70554c | 1.70 MiB | 2.28 MiB | 592.36 KiB |
5b9b5ac | 1.70 MiB | 2.28 MiB | 592.36 KiB |
97da736 | 1.70 MiB | 2.28 MiB | 592.27 KiB |
romtsn
reviewed
Apr 22, 2024
attachColdAppStartSpans(AppStartMetrics.getInstance(), transaction); | ||
sentStartMeasurement = true; | ||
final @Nullable App appContext = transaction.getContexts().getApp(); | ||
if (appContext != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l
: I know it should be set by the DefaultAndroidEventProcessor which is running before this one, but should we fall back to creating a new instance of App
in case it's null?
romtsn
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes #3178
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps