Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start_type to app context #3379

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Add start_type to app context #3379

merged 5 commits into from
Apr 23, 2024

Conversation

markushi
Copy link
Member

📜 Description

Fixes #3178

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 31a106c

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 522.44 ms 618.12 ms 95.68 ms
Size 1.70 MiB 2.28 MiB 592.36 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4e260b3 378.73 ms 454.18 ms 75.45 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms
0bd723b 395.44 ms 472.66 ms 77.22 ms
7275aa8 422.39 ms 456.94 ms 34.55 ms
baaf637 375.71 ms 441.58 ms 65.87 ms
7eccfdb 366.98 ms 440.27 ms 73.29 ms
937879e 417.64 ms 550.45 ms 132.81 ms
9119d59 407.12 ms 509.64 ms 102.52 ms
93a76ca 378.48 ms 451.78 ms 73.30 ms
93a76ca 377.96 ms 447.52 ms 69.56 ms

App size

Revision Plain With Sentry Diff
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
7275aa8 1.70 MiB 2.28 MiB 590.71 KiB
baaf637 1.72 MiB 2.27 MiB 558.42 KiB
7eccfdb 1.72 MiB 2.27 MiB 556.93 KiB
937879e 1.72 MiB 2.27 MiB 558.42 KiB
9119d59 1.70 MiB 2.27 MiB 583.84 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB

Previous results on branch: feat/app-context-start-type

Startup times

Revision Plain With Sentry Diff
a70554c 369.39 ms 438.65 ms 69.27 ms
5b9b5ac 375.58 ms 458.57 ms 82.99 ms
97da736 390.06 ms 465.79 ms 75.73 ms

App size

Revision Plain With Sentry Diff
a70554c 1.70 MiB 2.28 MiB 592.36 KiB
5b9b5ac 1.70 MiB 2.28 MiB 592.36 KiB
97da736 1.70 MiB 2.28 MiB 592.27 KiB

attachColdAppStartSpans(AppStartMetrics.getInstance(), transaction);
sentStartMeasurement = true;
final @Nullable App appContext = transaction.getContexts().getApp();
if (appContext != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: I know it should be set by the DefaultAndroidEventProcessor which is running before this one, but should we fall back to creating a new instance of App in case it's null?

@markushi markushi merged commit 0156268 into main Apr 23, 2024
24 checks passed
@markushi markushi deleted the feat/app-context-start-type branch April 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report app start type via app context
2 participants