Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hubs/Scopes Merge 41 - Use SentryOptions.empty() #3387

Merged
merged 49 commits into from
May 2, 2024
Merged

Hubs/Scopes Merge 41 - Use SentryOptions.empty() #3387

merged 49 commits into from
May 2, 2024

Conversation

adinauer
Copy link
Member

#skip-changelog

📜 Description

💡 Motivation and Context

Creating new SentryOptions implies also creating things like executor service that are costly to create. SentryOptions.empty() already delays some of those costly things, however we should also fix #2541 as a follow up.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer and others added 30 commits March 27, 2024 16:30
@adinauer
replace hub with scopes
305baf5
@adinauer
Add Scopes
95f5e1b
@adinauer
Introduce IScopes interface.
27f2398
@adinauer
Replace IHub with IScopes in core
ce3c14f
@adinauer
Replace IHub with IScopes in android core
ce615f4
@adinauer
Replace IHub with IScopes in android integrations
22ddc00
@adinauer
Replace IHub with IScopes in apollo integrations
305c217
@adinauer
Replace IHub with IScopes in okhttp integration
da927bc
@adinauer
Replace IHub with IScopes in graphql integration
8279276
@adinauer
Replace IHub with IScopes in logging integrations
9bfc086
@adinauer
Replace IHub with IScopes in more integrations
b998e50
@adinauer
Replace IHub with IScopes in OTel integration
739827a
@adinauer
Replace IHub with IScopes in Spring 5 / Spring Boot 2 integrations
69f2d63
@adinauer
Replace IHub with IScopes in Spring 6 / Spring Boot 3 integrations
792d482
@adinauer
Replace IHub with IScopes in samples
9bcbce6
@adinauer
Merge branch 'feat/hsm-13-replacements-in-samples' into feat/hubs-sco…
3f25a4b 
…pes-merge-2-add-scopes
@adinauer
gitscopes -> github
d6fb40a
@adinauer
Replace ThreadLocal with ScopesStorage
7752bcc
@adinauer
Move client and throwable to span map to scope
1e329c5
@adinauer
Add global scope
b0d89ae
@adinauer
use global scope in Scopes
cdd414a
@adinauer
Implement pushScope popScope and withScope for Scopes
98da9ff
@adinauer
Add pushIsolationScope; add fork methods to ISCope
2d26033
@adinauer
Use separate scopes for current, isolation and global scope; rename m…
bbb6700 
…ainScopes to rootScopes
@adinauer
Allow controlling which scope configureScope uses
c714b21
@adinauer
Combine scopes
a474402
@adinauer
Use new API for CRONS integrations
ae93e33
@adinauer
Add lifecycle helper
b01298b
@adinauer
Change spring integrations to use new API
b64e688
@adinauer
Use new API in servlet integrations
d06fc50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 12dda59

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 430.06 ms 494.71 ms 64.65 ms
Size 1.70 MiB 2.28 MiB 595.72 KiB

Previous results on branch: feat/hsm-41-empty-options

Startup times

Revision Plain With Sentry Diff
bf02f25 348.40 ms 395.62 ms 47.22 ms

App size

Revision Plain With Sentry Diff
bf02f25 1.70 MiB 2.28 MiB 595.65 KiB

lbloder
lbloder approved these changes Apr 28, 2024
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/hsm-40-enabled-checks-client to 8.x.x May 2, 2024 12:38
@adinauer adinauer merged commit 9b61758 into 8.x.x May 2, 2024
10 of 19 checks passed
@adinauer adinauer deleted the feat/hsm-41-empty-options branch May 2, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbloder lbloder lbloder approved these changes

@markushi markushi markushi approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adinauer @markushi @lbloder