Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report suppressed exceptions as exception group #3396

Merged
merged 61 commits into from
May 13, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Apr 29, 2024

📜 Description

Report exceptions returned by Throwable.getSuppressed() to Sentry as exception groups. They show up like this:

Screenshot 2024-04-29 at 16 42 41

Links can be clicked and take you to the exception on the same page.

💡 Motivation and Context

Fixes #542

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer and others added 30 commits March 27, 2024 16:30
Copy link
Contributor

github-actions bot commented Apr 29, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Report suppressed exceptions as exception group ([#3396](https://github.com/getsentry/sentry-java/pull/3396))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 18ad266

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 449.88 ms 525.45 ms 75.57 ms
Size 1.70 MiB 2.28 MiB 595.99 KiB

Previous results on branch: feat/hsm-42c-suppressed-exceptions

Startup times

Revision Plain With Sentry Diff
0a61517 394.71 ms 454.42 ms 59.71 ms
37d1e27 379.49 ms 423.67 ms 44.18 ms
99b5ed4 386.04 ms 460.83 ms 74.79 ms
25e1771 383.98 ms 459.50 ms 75.52 ms
1c2fbfe 403.73 ms 463.84 ms 60.11 ms
a23c145 396.22 ms 458.98 ms 62.76 ms
702ae01 403.63 ms 476.15 ms 72.51 ms
c822b54 431.59 ms 549.47 ms 117.88 ms
0c124b6 382.98 ms 458.90 ms 75.92 ms

App size

Revision Plain With Sentry Diff
0a61517 1.70 MiB 2.28 MiB 595.98 KiB
37d1e27 1.70 MiB 2.28 MiB 595.95 KiB
99b5ed4 1.70 MiB 2.28 MiB 595.99 KiB
25e1771 1.70 MiB 2.28 MiB 595.98 KiB
1c2fbfe 1.70 MiB 2.28 MiB 595.99 KiB
a23c145 1.70 MiB 2.28 MiB 595.97 KiB
702ae01 1.70 MiB 2.28 MiB 595.97 KiB
c822b54 1.70 MiB 2.28 MiB 595.97 KiB
0c124b6 1.70 MiB 2.28 MiB 595.97 KiB

Base automatically changed from feat/hsm-42-remove-hub to 8.x.x May 2, 2024 13:17
@rodolfoBee
Copy link
Member

Do we have an ETA for when it can be merged and released?

@adinauer
Copy link
Member Author

@rodolfoBee since we're merging this into 8.x it might be a couple weeks until we release an early alpha of 8.x as we want to include some changes around Performance powered by OTel.

@adinauer
Copy link
Member Author

@rodolfoBee we just discussed this internally and we're planning to merge this sooner and do an alpha release without Performance powered by OpenTelemetry. Just need to prepare some things for the release.

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit dc56a6a into 8.x.x May 13, 2024
8 of 19 checks passed
@adinauer adinauer deleted the feat/hsm-42c-suppressed-exceptions branch May 13, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants