Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust publications to publish gradle module metadata #3422

Merged
merged 7 commits into from
May 16, 2024
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented May 14, 2024

  • Packages and renames .module files into the final dist.zip, so they are ready to be published by craft
  • Makes sentry-compose-helper a compileOnly dependency, so it doesn't get added to the .pom and .module files
    • This has a side-effect that we have to specify it explicitly as implementation for the modules that are using sentry-compose. Our customers are still fine though, as we embed the classes from the -helper module and it's published to maven like that

Relevant PR in craft: getsentry/craft#535
Closes #2233

@romtsn romtsn enabled auto-merge (squash) May 14, 2024 22:02
Copy link
Contributor

github-actions bot commented May 14, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 387.27 ms 465.73 ms 78.46 ms
Size 1.70 MiB 2.28 MiB 592.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7ca9895 364.31 ms 460.46 ms 96.15 ms
bf82eb3 423.76 ms 506.45 ms 82.69 ms
d429384 397.33 ms 457.69 ms 60.36 ms
f5e1b97 362.53 ms 429.31 ms 66.78 ms
c554ca2 368.52 ms 430.74 ms 62.22 ms
9119d59 407.12 ms 509.64 ms 102.52 ms
a33b076 381.94 ms 459.64 ms 77.71 ms
93a76ca 397.30 ms 455.16 ms 57.87 ms
283d83e 348.44 ms 392.06 ms 43.62 ms
9e57f46 368.94 ms 410.50 ms 41.56 ms

App size

Revision Plain With Sentry Diff
7ca9895 1.72 MiB 2.29 MiB 576.51 KiB
bf82eb3 1.70 MiB 2.28 MiB 587.99 KiB
d429384 1.72 MiB 2.27 MiB 558.42 KiB
f5e1b97 1.70 MiB 2.28 MiB 592.00 KiB
c554ca2 1.70 MiB 2.27 MiB 582.25 KiB
9119d59 1.70 MiB 2.27 MiB 583.84 KiB
a33b076 1.70 MiB 2.28 MiB 592.32 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
283d83e 1.72 MiB 2.29 MiB 577.69 KiB
9e57f46 1.70 MiB 2.28 MiB 592.08 KiB

Previous results on branch: rz/fix/publications

Startup times

Revision Plain With Sentry Diff
df921fc 424.75 ms 495.76 ms 71.01 ms
e164c0d 472.90 ms 569.70 ms 96.80 ms
3268987 411.21 ms 491.78 ms 80.57 ms

App size

Revision Plain With Sentry Diff
df921fc 1.70 MiB 2.28 MiB 592.11 KiB
e164c0d 1.70 MiB 2.28 MiB 592.08 KiB
3268987 1.70 MiB 2.28 MiB 592.11 KiB

@romtsn romtsn force-pushed the rz/fix/publications branch from cee0ad5 to 25dadc6 Compare May 15, 2024 09:08
@romtsn romtsn disabled auto-merge May 15, 2024 09:24
@romtsn romtsn changed the base branch from release/7.10.0-SNAPSHOT to main May 15, 2024 11:15
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@romtsn romtsn enabled auto-merge (squash) May 16, 2024 09:39
@romtsn romtsn merged commit 0a2d0b6 into main May 16, 2024
23 of 24 checks passed
@romtsn romtsn deleted the rz/fix/publications branch May 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle pom.xml incorrect metadata redirection
2 participants