Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data fetching environment hint to breadcrumb (#3413) #3431

Merged
merged 6 commits into from
May 28, 2024

Conversation

ooraini
Copy link

@ooraini ooraini commented May 17, 2024

📜 Description

See #3413

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer
Copy link
Member

Thanks for the PR @ooraini. I can't say when I'll to doing a full review. An initial glance looks good. I'll retarget this on the v8 branch if you don't mind.

@lbloder lbloder changed the base branch from main to 8.x.x May 24, 2024 12:04
@lbloder lbloder changed the base branch from 8.x.x to main May 27, 2024 20:33
@lbloder lbloder changed the base branch from main to 8.x.x May 27, 2024 20:33
@lbloder
Copy link
Collaborator

lbloder commented May 27, 2024

Hi @ooraini,
As already mentioned by @adinauer, I rebased this PR to the 8.x.x branch.

Your changes look good, thank you for your PR 👍
I just added a test and a changelog entry

@lbloder lbloder merged commit c2f2cc7 into getsentry:8.x.x May 28, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants