Move onFinishCallback before span or transaction is finished

[stefanosiano]

📜 Description

moved span and transaction finish callback before they are actually finished

💡 Motivation and Context

Closes #3228
This fixes and aligns the behaviour among spans and transactions.

💚 How did you test it?

Unit tests

📝 Checklist

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[stefanosiano]

I moved the performanceCollectors here, to fix an issue with SpanFrameMetricsCollection which was not setting the frame counts measurements, due to transaction being already finished

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	381.92 ms	468.09 ms	86.17 ms
Size	1.70 MiB	2.28 MiB	592.46 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
d6d2b2e	463.14 ms	545.56 ms	82.42 ms
a3c77bc	375.80 ms	445.85 ms	70.06 ms
c7e2fbc	377.85 ms	426.35 ms	48.50 ms
f5e1b97	362.53 ms	429.31 ms	66.78 ms
7eccfdb	389.94 ms	461.29 ms	71.35 ms
f1fdb9f	404.21 ms	496.87 ms	92.66 ms
28c9a83	346.14 ms	377.76 ms	31.62 ms
baaf637	375.71 ms	441.58 ms	65.87 ms
283d83e	348.44 ms	392.06 ms	43.62 ms
61981dc	388.65 ms	454.96 ms	66.31 ms

App size

Revision	Plain	With Sentry	Diff
d6d2b2e	1.72 MiB	2.27 MiB	555.05 KiB
a3c77bc	1.72 MiB	2.29 MiB	577.53 KiB
c7e2fbc	1.72 MiB	2.29 MiB	576.40 KiB
f5e1b97	1.70 MiB	2.28 MiB	592.00 KiB
7eccfdb	1.72 MiB	2.27 MiB	556.93 KiB
f1fdb9f	1.70 MiB	2.28 MiB	592.08 KiB
28c9a83	1.70 MiB	2.28 MiB	592.00 KiB
baaf637	1.72 MiB	2.27 MiB	558.42 KiB
283d83e	1.72 MiB	2.29 MiB	577.69 KiB
61981dc	1.70 MiB	2.28 MiB	592.12 KiB

Previous results on branch: fix/finish-callback-before-finish

Startup times

Revision	Plain	With Sentry	Diff
20d2b9c	393.92 ms	465.33 ms	71.41 ms
eccd5d2	371.11 ms	433.60 ms	62.50 ms

App size

Revision	Plain	With Sentry	Diff
20d2b9c	1.70 MiB	2.28 MiB	592.75 KiB
eccd5d2	1.70 MiB	2.28 MiB	592.33 KiB

[markushi]

Nice one!

[markushi]

nit this probably should be volatile, but then on the other hand we also don't do this for other span properties ¯_(ツ)_/¯

[stefanosiano]

let's keep AtomicBoolean and change it later if ever needed, as i don't think it really changes anything