Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions when closing integrations #3488

Merged
merged 73 commits into from
Jun 24, 2024

Conversation

adinauer
Copy link
Member

📜 Description

Catch exceptions thrown by Integration.close()

💡 Motivation and Context

An exception thrown by an integration on close interrupts Sentry.close() which can cause problems, e.g. with tests that are executed in a suite or re-init of the SDK.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer and others added 30 commits March 27, 2024 16:30
Copy link
Contributor

github-actions bot commented Jun 17, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Catch exceptions when closing integrations ([#3488](https://github.com/getsentry/sentry-java/pull/3488))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against efb3601

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 458.25 ms 534.84 ms 76.59 ms
Size 1.70 MiB 2.28 MiB 596.08 KiB

Baseline results on branch: feat/reuse-traces-sampler

Startup times

Revision Plain With Sentry Diff
3d82da7 452.02 ms 509.15 ms 57.13 ms

App size

Revision Plain With Sentry Diff
3d82da7 1.70 MiB 2.28 MiB 596.08 KiB

Base automatically changed from feat/reuse-traces-sampler to 8.x.x June 18, 2024 10:30
@adinauer adinauer merged commit eff6399 into 8.x.x Jun 24, 2024
0 of 19 checks passed
@adinauer adinauer deleted the feat/catch-exceptions-on-integration-close branch June 24, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants