Parse and use send-default-pii
and max-request-body-size
from sentry.properties
#3534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
We now parse and use
send-default-pii
andmax-request-body-size
fromsentry.properties
.max-request-body-size
was already being parsed but never applied toSentryOptions
send-default-pii
was neither parsed nor applied💡 Motivation and Context
As of
8.0.0-alpha.2
our Sentry OpenTelemetry Java Agent has been released and is supposed to be a vital part in our future Performance instrumentation. Some features (e.g. error reporting) are currently still based on the integrations that existed before.Some data is only sent when certain options are enabled (see PR title). We never parsed those until now, meaning our OpenTelemetry Agent Init wasn't able to utilize all of the functionality Sentry offers.
NOTE: There might be more options, that aren't parsed yet. We should investigate and fix. Here's an issue for that: #3535
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps