Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and use send-default-pii and max-request-body-size from sentry.properties #3534

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jul 1, 2024

📜 Description

We now parse and use send-default-pii and max-request-body-size from sentry.properties.

  • max-request-body-size was already being parsed but never applied to SentryOptions
  • send-default-pii was neither parsed nor applied

💡 Motivation and Context

As of 8.0.0-alpha.2 our Sentry OpenTelemetry Java Agent has been released and is supposed to be a vital part in our future Performance instrumentation. Some features (e.g. error reporting) are currently still based on the integrations that existed before.

Some data is only sent when certain options are enabled (see PR title). We never parsed those until now, meaning our OpenTelemetry Agent Init wasn't able to utilize all of the functionality Sentry offers.

NOTE: There might be more options, that aren't parsed yet. We should investigate and fix. Here's an issue for that: #3535

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ef21d8c

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 423.20 ms 499.43 ms 76.23 ms
Size 1.70 MiB 2.29 MiB 599.77 KiB

Previous results on branch: feat/parse-more-external-options

Startup times

Revision Plain With Sentry Diff
7dc921a 454.49 ms 522.39 ms 67.90 ms

App size

Revision Plain With Sentry Diff
7dc921a 1.70 MiB 2.29 MiB 599.50 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch 👍

@adinauer adinauer merged commit c7232fe into 8.x.x Jul 2, 2024
20 of 21 checks passed
@adinauer adinauer deleted the feat/parse-more-external-options branch July 2, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants