Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spans that are split into multiple batches #3539

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jul 2, 2024

📜 Description

Invert isSpanTooOld check so spans that haven't been sent to Sentry yet survive until the next invocation of SpanExporter.export.

💡 Motivation and Context

When spans belonging to a single transaction were split into multiple batches for SpanExporter, we did not add all spans because the isSpanTooOld check wasn't inverted.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 414.90 ms 466.55 ms 51.65 ms
Size 1.70 MiB 2.29 MiB 599.77 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit a62056e into 8.x.x Jul 2, 2024
21 checks passed
@adinauer adinauer deleted the fix/support-spans-across-batches branch July 2, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants