Support spans that are split into multiple batches #3539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Invert
isSpanTooOld
check so spans that haven't been sent to Sentry yet survive until the next invocation ofSpanExporter.export
.💡 Motivation and Context
When spans belonging to a single transaction were split into multiple batches for
SpanExporter
, we did not add all spans because theisSpanTooOld
check wasn't inverted.💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps