Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC - Use correct options on re-init #3540

Closed
wants to merge 4 commits into from

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jul 2, 2024

📜 Description

On multi init we now only do the bare minimum with the new options. Since the new options might not be used, defer init of certain things until we know whether the new options are actually being used (replaced on global scope).

We can build on top of this to control re-init behaviour once we've decided on which route we want to go there.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer changed the title Support spans across batches POC - Use correct options on re-init Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POC - Use correct options on re-init ([#3540](https://github.com/getsentry/sentry-java/pull/3540))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against bec16db

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 427.43 ms 515.63 ms 88.20 ms
Size 1.70 MiB 2.29 MiB 599.60 KiB

Baseline results on branch: 8.x.x

Startup times

Revision Plain With Sentry Diff
a59fca2 560.08 ms 658.80 ms 98.71 ms

App size

Revision Plain With Sentry Diff
a59fca2 1.70 MiB 2.29 MiB 599.77 KiB

@adinauer
Copy link
Member Author

adinauer commented Sep 2, 2024

Closed in favor of #3674

@adinauer adinauer closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant