Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Spring Boot to 3.3.2 #3541

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Bump Spring Boot to 3.3.2 #3541

merged 5 commits into from
Jul 29, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jul 2, 2024

📜 Description

Replaces #3482

💡 Motivation and Context

Spring Boot 3.3.0 onwards depends on org.apache.commons:commons-compress:1.25.0 and no longer works with org.apache.commons:commons-compress as provided by com.android.tools.build:gradle:7.4.2 (v 1.2.0) to com.android.tools.build:gradle:8.5.0 (v 1.2.1).

Leading to a Build Error, as the Spring Boot plugin expects void org.apache.commons.compress.archivers.zip.ZipArchiveOutputStream.putArchiveEntry to be a generic method.

Related changes in SpringBoot and Apache Commons:
spring-projects/spring-boot@10e750a

apache/commons-compress@rel/commons-compress-1.24.0...rel/commons-compress-1.25.0#diff-19b93108b5

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d1face4

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lbloder
Copy link
Collaborator

lbloder commented Jul 22, 2024

@romtsn Would you mind having a quick look at this? I had to upgrade the org.apache.commons:commons-compress dependency. Through the android sdk an older version of it is supplied, do you think this could have a negative impact on Android?

@romtsn
Copy link
Member

romtsn commented Jul 22, 2024

@romtsn Would you mind having a quick look at this? I had to upgrade the org.apache.commons:commons-compress dependency. Through the android sdk an older version of it is supplied, do you think this could have a negative impact on Android?

if the CI is green then I think it's all good, otherwise there would've been a build-time error

@lbloder
Copy link
Collaborator

lbloder commented Jul 22, 2024

@romtsn Thanks for having a look. Yeah, that's what I thought too, just wanted to be sure :)

@lbloder lbloder changed the title Bump Spring Boot to 3.3.1 Bump Spring Boot to 3.3.2 Jul 29, 2024
@lbloder lbloder merged commit 3a89243 into main Jul 29, 2024
24 checks passed
@lbloder lbloder deleted the feat/bump-spring-boot-3 branch July 29, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants