[SR] Capture Replays for ANRs and crashes #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replay-map-object-reader
…replay-map-object-reader
…replay-map-object-reader
…ject-reader [SR] Introduce MapObjectReader
| } | ||
|
|
||
| // we need to round to the nearest frame to include breadcrumbs/events happened after the frame was captured | ||
| val duration = roundToNearestFrame( |
There was a problem hiding this comment.
Suggested change
| val duration = roundToNearestFrame( | |
| val durationMillis = roundToNearestFrame( |
There was a problem hiding this comment.
will address in the other PR since this line has changed there
sentry-android-replay/src/main/java/io/sentry/android/replay/capture/BaseCaptureStrategy.kt
Outdated
Show resolved
Hide resolved
markushi
approved these changes
Jul 30, 2024
sentry-android-core/src/main/java/io/sentry/android/core/AnrV2EventProcessor.java
Outdated
Show resolved
Hide resolved
| isClosed.set(true) | ||
| } | ||
|
|
||
| // TODO: it's awful, choose a better serialization format |
There was a problem hiding this comment.
Would appending only the new items to the file work better?
sentry-android-replay/src/main/java/io/sentry/android/replay/capture/BaseCaptureStrategy.kt
Outdated
Show resolved
Hide resolved
romtsn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
The main changes are:
ANRs part
replay_idfrom scope to diskpropagationContextin case there's no active transaction on scope, to always have a trace to link toReplay part
BaseCaptureStrategy.createSegmentmethod fully parameterized, to supply things like breadcrumbs/rrweb events/segment values not only from the current app run, but also from the previously serialized values when neededTODO leftovers
There are some leftovers which (imo) is fine to address later, namely:
traceContextfor replay events from the event values, when the event is Backfillable (=sent on next app launch).options_cachefor that), when the event is Backfillable (=sent on next app launch)💡 Motivation and Context
Part of getsentry/sentry#70065
💚 How did you test it?
Manually + automated
Next up
Do the same for crashes and JS crashes, and after that get to the buffer mode as it's a bit more work there
Example ANR with a linked replay
https://sentry-sdks.sentry.io/issues/5587028220/events/635b45b8a6254aa29f8d4f1734480613