Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change payload for Continuous Profiling (p2) #3695

Open
wants to merge 1 commit into
base: feat/continuous-profiling-p1
Choose a base branch
from

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Sep 17, 2024

📜 Description

added profile_chunk envelope create
added IHub.captureProfileChunk and ISentryClient.captureProfileChunk
added profilerId and chunkId reset logic to AndroidContinuousProfiler
added absolute timestamps to ProfileMeasurementValue
added ProfileContext to Contexts

#skip-changelog

💡 Motivation and Context

Implements payload changes for Continuous Profiling
Part 2 of #3683

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

added IHub.captureProfileChunk and ISentryClient.captureProfileChunk
added profilerId and chunkId reset logic to AndroidContinuousProfiler
added absolute timestamps to ProfileMeasurementValue
added ProfileContext to Contexts
Copy link
Contributor

github-actions bot commented Sep 17, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a3d904d

@stefanosiano stefanosiano changed the title Feat/continuous profiling p2 Change Payload for Continuous Profiling (p2) Sep 17, 2024
@stefanosiano stefanosiano changed the title Change Payload for Continuous Profiling (p2) Change payload for Continuous Profiling (p2) Sep 17, 2024
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 430.34 ms 434.14 ms 3.80 ms
Size 1.70 MiB 2.35 MiB 663.19 KiB

@stefanosiano stefanosiano changed the base branch from main to feat/continuous-profiling-p1 September 17, 2024 15:40
@stefanosiano stefanosiano marked this pull request as ready for review September 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant