Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enable tracing from android sample manifest #3792

Merged

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Oct 15, 2024

#skip-changelog

📜 Description

Remove the io.sentry.traces.enable meta-data from AndroidManifest.xml in the Android Sample.
Update description of io.sentry.traces.sample-rate.

💡 Motivation and Context

enableTracing has been removed in v8, therefore the io.sentry.traces.enable value in the AndroidManifest.xml has no effect and needs to be removed to not cause confusion or users.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer merged commit f237379 into 8.x.x Oct 15, 2024
17 of 19 checks passed
@adinauer adinauer deleted the fix/remove-enable-tracing-from-android-sample-manifest branch October 15, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants