Add globalHubMode to options
#3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
|
Performance metrics 🚀
|
lbloder
reviewed
Oct 18, 2024
| @@ -279,10 +278,12 @@ private static void init(final @NotNull SentryOptions options, final boolean glo | |||
| return; | |||
| } | |||
|
|
|||
| final boolean globalHubModeToUse = | |||
There was a problem hiding this comment.
(l) getting an IDE warning here for a possible null-pointer due to options.isGlobalHubMode changing between checks. We could extract a final Boolean globalHubModeFromOptions = options.isGlobalHubMode() and use that in the ternary operator
There was a problem hiding this comment.
Ah yeah, forgot to do that, will update
stefanosiano
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
globalHubModeused to only be a param onSentry.init. To make it easier to be used in e.g. Desktop environments, we now additionally added it as an option onSentryOptionsthat can also be set viasentry.properties.We can consider deprecating and removing the
Sentry.initoverloads that have theglobalHubModeparameter.If both the param on
Sentry.initand the option are set, the option will win. By default the option is set tonullmeaning whatever is passed toSentry.initwins.💡 Motivation and Context
Fixes #3779
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps