Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test(ui): Add critical tests run by Maestro (#3802)" #3813

Closed
wants to merge 1 commit into from
Closed

Revert "test(ui): Add critical tests run by Maestro (#3802)" #3813

wants to merge 1 commit into from

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Oct 23, 2024 •
edited
Loading

📜 Description

This reverts commit 4988d5b.

Introduced in #3802

💡 Motivation and Context

Build job on main was timing out after this change.

The build job in the PR finished successfully.

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 444.10 ms 490.55 ms 46.44 ms
Size 1.70 MiB 2.35 MiB 667.95 KiB

@krystofwoldrich krystofwoldrich mentioned this pull request Oct 23, 2024
Merged
7 tasks
@krystofwoldrich
Copy link
Member Author

Merge this if you are blocked by the timeout of the build step.

@krystofwoldrich
Copy link
Member Author

Timeout was fixed in #3814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krystofwoldrich