Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisabledQueue.isEmpty now returns true #3927

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Nov 25, 2024

📜 Description

DisabledQueue.isEmpty now returns true

#skip-changelog

💡 Motivation and Context

This isn't really used anywhere, but it's conceptually correct for the DisabledQueue to return true on isEmpty()
Left from another PR

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review November 25, 2024 11:28
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 452.48 ms 488.37 ms 35.90 ms
Size 1.65 MiB 2.31 MiB 676.08 KiB

@stefanosiano stefanosiano merged commit e08357c into 8.x.x Dec 3, 2024
29 checks passed
@stefanosiano stefanosiano deleted the fix/disabled-queue-empty-true branch December 3, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants