ref(gatsby): Default release to empty string

To make gatsby work better out of the box, we set the default for the release value to be undefined instead of an empty string.
getsentry · Jun 28, 2021 · 14abbb1 · 14abbb1
1 parent 8ea6c9d
commit 14abbb1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/gatsby/gatsby-node.js b/packages/gatsby/gatsby-node.js
@@ -11,7 +11,7 @@ const sentryRelease = JSON.stringify(
     process.env.ZEIT_GITHUB_COMMIT_SHA ||
     process.env.ZEIT_GITLAB_COMMIT_SHA ||
     process.env.ZEIT_BITBUCKET_COMMIT_SHA ||
-    '',
+    undefined,
 );
 
 const sentryDsn = JSON.stringify(process.env.SENTRY_DSN || '');

diff --git a/packages/gatsby/test/gatsby-node.test.ts b/packages/gatsby/test/gatsby-node.test.ts
@@ -18,7 +18,7 @@ describe('onCreateWebpackConfig', () => {
     expect(plugins.define).toHaveBeenCalledTimes(1);
     expect(plugins.define).toHaveBeenLastCalledWith({
       __SENTRY_DSN__: expect.any(String),
-      __SENTRY_RELEASE__: expect.any(String),
+      __SENTRY_RELEASE__: undefined,
     });
 
     expect(actions.setWebpackConfig).toHaveBeenCalledTimes(1);