-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(serverlesss): allow disabling transaction traces (#9154)
## Background - My team runs Express inside Lambda - we have a monolithic Lambda function with express handling routing, middleware, etc - We are using `@sentry/node` today, and tried adding `@sentry/serverless` for it's timeout warning, auto-handling of `flush`, and links to cloudwatch logs - But this caused all of our performance transaction traces to have an incorrect name (and various other tag + context issues) ## Proposal - A new `startTrace` boolean flag that turns on/off the transaction tracing feature of `@sentry/serverless` - This will allow our team to use `@sentry/serverless`, but still rely on express `tracingHandler` for performance traces - This also follows the general approach of the serverless package, where each feature is gated by a wrapOptions flag
- Loading branch information
1 parent
e507110
commit 28b6d75
Showing
3 changed files
with
76 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters