Skip to content

Commit

Permalink
fix(feedback): Update typing for v7
Browse files Browse the repository at this point in the history
  • Loading branch information
AbhiPrasad committed Feb 29, 2024
1 parent 17744cd commit 868a20e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

- **feat(performance): create Interaction standalone spans on inp events (#10709)**

This release adds support for the INP web vital. This is currently only supported for Saas Sentry, and product support is released with
the upcoming `24.3.0` release of self-hosted.
This release adds support for the INP web vital. This is currently only supported for Saas Sentry, and product support
is released with the upcoming `24.3.0` release of self-hosted.

To opt-in to this feature, you can use the `enableInp` option in the `browserTracingIntegration`:

Expand Down
3 changes: 2 additions & 1 deletion packages/feedback/src/util/sendFeedbackRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ export async function sendFeedbackRequest(
}

const feedbackEvent = await prepareFeedbackEvent({
scope,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
scope: scope as any,
client,
event: baseEvent,
});
Expand Down
5 changes: 4 additions & 1 deletion packages/feedback/src/widget/createWidget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ export function createWidget({
function handleOpenDialog(): void {
// Flush replay if integration exists
const client = getClient();
const replay = client && client.getIntegrationByName<{ name: string; flush: () => Promise<void> }>('Replay');
const replay =
client &&
client.getIntegrationByName &&
client.getIntegrationByName<{ name: string; flush: () => Promise<void>; setupOnce: () => void }>('Replay');
if (!replay) {
return;
}
Expand Down

0 comments on commit 868a20e

Please sign in to comment.