ref(integrations): Minor simplification of ExtraErrorData code (#4024)

getsentry · Oct 4, 2021 · d1c471f · d1c471f
1 parent 389ae60
commit d1c471f
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/packages/integrations/src/extraerrordata.ts b/packages/integrations/src/extraerrordata.ts
@@ -75,7 +75,6 @@ export class ExtraErrorData implements Integration {
    * Extract extra information from the Error object
    */
   private _extractErrorData(error: ExtendedError): { [key: string]: unknown } | null {
-    let result = null;
     // We are trying to enhance already existing event, so no harm done if it won't succeed
     try {
       const nativeKeys = ['name', 'message', 'stack', 'line', 'column', 'fileName', 'lineNumber', 'columnNumber'];
@@ -84,18 +83,15 @@ export class ExtraErrorData implements Integration {
       if (errorKeys.length) {
         const extraErrorInfo: { [key: string]: unknown } = {};
         for (const key of errorKeys) {
-          let value = error[key];
-          if (isError(value)) {
-            value = (value as Error).toString();
-          }
-          extraErrorInfo[key] = value;
+          const value = error[key];
+          extraErrorInfo[key] = isError(value) ? (value as Error).toString() : value;
         }
-        result = extraErrorInfo;
+        return extraErrorInfo;
       }
     } catch (oO) {
       logger.error('Unable to extract extra data from the Error object:', oO);
     }
 
-    return result;
+    return null;
   }
 }