ref(profiling) Fix electron crash

getsentry · Nov 8, 2024 · ed3d79d · ed3d79d
1 parent a91a5ba
commit ed3d79d
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/profiling-node/bindings/cpu_profiler.cc b/packages/profiling-node/bindings/cpu_profiler.cc
@@ -331,11 +331,10 @@ void SentryProfile::Start(Profiler *profiler) {
   started_at = uv_hrtime();
   timestamp = timestamp_milliseconds();
 
-  // Initialize the CPU Profiler
-  profiler->cpu_profiler->StartProfiling(
-      profile_title,
-      {v8::CpuProfilingMode::kCallerLineNumbers,
-       v8::CpuProfilingOptions::kNoSampleLimit, kSamplingInterval});
+// Initialize the CPU Profiler
+profiler->cpu_profiler
+      ->StartProfiling(profile_title, v8::CpuProfilingMode::kCallerLineNumbers,
+                       true, v8::CpuProfilingOptions::kNoSampleLimit);
 
   // listen for memory sample ticks
   profiler->measurements_ticker.add_cpu_listener(id, cpu_sampler_cb);
@@ -1169,6 +1168,7 @@ napi_value Init(napi_env env, napi_value exports) {
   }
 
   Profiler *profiler = new Profiler(env, isolate);
+  profiler->cpu_profiler->SetSamplingInterval(kSamplingInterval);
 
   if (napi_set_instance_data(env, profiler, FreeAddonData, NULL) != napi_ok) {
     napi_throw_error(env, nullptr, "Failed to set instance data for profiler.");