-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Vue 3 #2925
Comments
I haven't tested it fully but passing the app instance instead of the global import { createApp } from 'vue';
import { Vue as VueIntegration } from '@sentry/integrations';
const app = createApp(App);
Sentry.init({
...
// instead of passing Vue default export
integrations: [new VueIntegration({ Vue: app })],
}); |
Oh, that's right, I didn't think about doing this. But, if we initialize Sentry after creating our Vue app, it means that Sentry won't be able to capture errors that happens in |
@Kocal I'm new to Vue but my guess is most of that happens when you call |
Yes that's true, however it's less "immediate" than before... but I guess we can't do much. I've identified some breaking changes when using Vue 3:
|
Also interested in this for my new vue 3 app with sentry |
This is actually a blocking requirement for us, we are really interested in resolving this. Maybe I can somehow help |
@onmyflow I'm currently scheduled to write a standalone |
I tried @paulshen 's way ; it looks so close yet so far, as I get the following error:
|
Same issue here, would be great to have sentry support for Vue 3 |
Any news on this? |
This is a blocking issue for Vue 3 upgrade for my application :-(. Any update on this? |
One issue is #2953 which splits the Vue integration in another package Also, should we keep Vue 2 support? |
I think we should keep Vue 2 support, because most of Vue Developers are still using Vue2. |
Also, how we will handle event for lifcycle hooks ( |
I think it's right that splits the Vue integration in another package |
ping @HazAT 👀 |
Any ETA on support for Vue3 |
I'd also be interested in a timeline. Thank you! |
I get same problem.So this problem has been resolved? |
Any news on this? |
Does Sentry support Vue 3? |
@paulshen I guess I am missing something, but from where should I get that |
@domasgru I've updated the comment. It's from import { Vue as VueIntegration } from '@sentry/integrations'; |
We are aware of the need for Vue 3 support and will try to work on it shortly. Will keep everyone posted! |
That's a great news, thanks! |
I can't get it to work
|
any news on this? |
@paulshen Thanks, but it not work in my project. BG: vue@3.0.5 |
@starker-xp maybe you could include in your comment the |
@vrusua Vue3 integration (with Quasar) works for me using both the answers provided by starker-xp . Even the sourcemap upload with webpack-pluging works. Here's the packages/versions used (no need to install
|
@h3 can you explain how you use the sourcemaps? With the Vue integration I could see the line where the error originated, but with @starker-xp solution I can't |
Done |
@andresespinosapc After verification it looks like the code/lines are indeed missing from the sentry error even with source maps being uploaded. Seems like we have no choice but to wait for the proper Vue 3 support .. sadly it doesn't seem there's much movements in that direction :( |
This is depressing 😔. I love sentry and want to keep using it but with no proper support in sight we are now having to consider other platforms. At least if we had some sort of roadmap we could plan around it. The workarounds are "ok" but don't really cut it. All our new project are embracing vue3 but we are blocked on this. |
Perhaps it's because I'm new to Sentry, but it appears to be working as expected with the workaround from @starker-xp in his comment: #2925 (comment) |
A certain amount works and it's ok. But the integration isn't as good as vue 2 and some things are not quite right. |
I've been using an implementation similar to @starker-xp since the release of Vue 3 in production and its been working fine for me, source maps and all. The only difference is that I'm recording it in the errorCaptured function instead but it seems to work the same as the global option. I would just make sure that the |
One issue that I have frequently is |
EDIT: See #3804 While we wait patiently, I took a stab at a vue 3 port: https://github.com/tjk/sentry-vue3#readme. Please check it out CAREFULLY and let me know if it works / doesn't work -- maybe we can get something decent in the interim. Main changes are:
|
Do you have an ETA on Vue 3 support? |
It's "finally" here. #3804 |
Vue 3 support has been released as
The how-to guide can be found in this PR: #3804 Would really appreciate some community testing before we released it as |
@kamilogorek great work! Where would you like (future) feedback? I've seen one error from Example sentry events:
|
@kamilogorek I experienced this error using the beta package you published. Seems to originate within the package itself.
I am initializing like this
|
@david-wb that is the exact same issue commented above and fixed via #3816. Fix should be included in 6.10.0-beta.2. |
Shipped in |
I have tried to update the code related the instruction https://docs.sentry.io/platforms/javascript/guides/vue/ Now I see the browser sends event data to the sentry server and gets the correct answers: But I see no new errors/issues in the sentry dashboard. Looks like all events were dropped (as incorrect or ... ?) (( |
@m00nk is this error or a session request though? Because by default you shouldn't get any errors obviously, and sessions can be seen in project page, not issues. see https://docs.sentry.io/product/releases/health/ |
@kamilogorek I assume this is error. I have made a fake error in my code and run throw new Error('My Error'); and I see the browser sent the request to the sentry server and got an answer. So the issue has to be shown in the project dahsboard, but the issues/errors page is empty (see the screenshots above). |
@m00nk you can go to |
@kamilogorek I have opened |
@m00nk had a similar issue which was twofold, first it was the sentry returning a 429 (api throttling) and after a while errors started being sent correctly (I had a unique hash in the response) but I still did not see anything in the Issues section. In my case it was the environment detection that failed so the payload were sent in the production environment while I was looking in the development issues. You can verify this is not your case by making sure you have no environment selected (top bar), it should say "All Environments". |
@h3 Thanks for the idea. I have checked the environments settings at it is "All Environments". Also about 2 weeks ago all my other projects (most of them are PHP-base) stopped to catch any issues too. So now all my projects have no issues at all for last two weeks. I did not change anything on those other projects mot the half of year. I assume the Sentry team made some critical changes so old code is not working now too (( |
@m00nk can you send me your org/project to email/discord? I'll see if there's something going one. |
Hi!
Vue 3 has been released yesterday and I would like to know if its support was planned, or if I can help on it.
Thanks!
The text was updated successfully, but these errors were encountered: