-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8] Remove @sentry/hub
package
#5665
Comments
Why didn't do it in the first place? |
Maybe @kamilogorek can offer us some history listens on why hub was made a seperate package. |
Whole |
Would it be possible to move the hub code without breaking the public API? We could move the code to The only reason I suggest this is because it becomes easier to make the changes and iterate on the codebase without creating a load of merge conflicts as v8 approaches. When we get to v8 we'd simply remove the The only downside I can see is that we'd be exporting the types from two different packages at the same time. |
I'm going to go ahead and make the call for us to do this, esp if it makes the work in #5611 easier.
Internally, we can shift to only depending on core, so the chances of this causing issues will decrease. |
We already do this all over the place, because most wrapper SDKs re-export stuff from the SDKs they wrap. I don't think it's an issue. |
I've reopened this and it can be closed when |
Happy about this change! 🚀 |
closes #5665 Goodbye hub package, I've known you my whole (sentry) life. Moved tests into core where applicable, otherwise deleted tests that were redundant.
Problem Statement
We have both https://github.com/getsentry/sentry-javascript/tree/master/packages/hub and https://github.com/getsentry/sentry-javascript/tree/master/packages/core, and there should never be a situation where you import
@sentry/hub
and you aren't using@sentry/core
. As such, we should just consolidate this into 1 package (move everything in@sentry/hub
into@sentry/core
.)The text was updated successfully, but these errors were encountered: