fix(core): Take user from current scope when starting a session #10153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Jan 11, 2024
| @@ -413,7 +413,7 @@ export function endSession(): void { | |||
| const isolationScope = getIsolationScope(); | |||
| const currentScope = getCurrentScope(); | |||
|
|
|||
| const session = isolationScope.getSession(); | |||
| const session = currentScope.getSession() || isolationScope.getSession(); | |||
There was a problem hiding this comment.
I think this was also incorrect before
Lms24
force-pushed
the
lms/fix-core-session-initialscope
branch
from
774bc3b to
392a5cf
Compare
size-limit report 📦
|
mydea
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a session, we previously only read the user from the isolation scope. This was problematic because the user could be set in
initialScopewhich will be applied to the current scope on SDK init. This would happen before the session is started when using auto session tracking.This PR now takes the user from the current scope if it's set and falls back to the isolation scope should the user be set there. Added an integration test to cover this regression.
fixes #10146
cc @timfish