ref(wasm): Convert wasm integration to functional integration #10230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
reviewed
Jan 18, 2024
| * Process WASM stack traces to support server-side symbolication. | ||
| * | ||
| * This also hooks the WebAssembly loading browser API so that module | ||
| * registrations are intercepted. |
There was a problem hiding this comment.
while at it, let's deprecate this in favor of the function?
|
Moving this to browser in v8 makes sense to me, I think. I don't know a whole lot about wasm to be honest, but there is nothing in here which appears overly special 🤔 |
Okay so it can be used in Node as well, but it's not WinterCG so not available in every runtime :/ Maybe let's keep it a separate package for now then, just evaluate this later. |
mydea
approved these changes
Jan 19, 2024
Lms24
added a commit
that referenced
this pull request
Jan 22, 2024
By using functional integrations in #10230, we started importing from `@sentry/core` in the WASM integration. However, we didn't register `@sentry/core` as a dependency, making rollup bundle core into the package output. This changed the `build/npm` directory structure, making our entry points in `package.json` invalid. This PR fixes things by simply registering core as a dependency of wasm. If we move WASM to core (which I strongly think we should do), we'll be able to get rid of this again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should think about moving the wasm integration into
@sentry/browserand removing@sentry/wasmall together. What do you think?