Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-experimental): Add koa integration #10451

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 1, 2024

This should auto-instrument Koa performance. We still needs tests for this at some point. cc @timfish / @onurtemizkan

The main reason to add this is that we have docs for this on docs.sentry.com, and we need a way to properly replace/update them (and they currently rely a lot on startTransaction() etc.) With this we can eventually just update this to use the default koa integration we provide.

@mydea mydea requested review from lforst and Lms24 February 1, 2024 10:04
@mydea mydea self-assigned this Feb 1, 2024
@timfish
Copy link
Collaborator

timfish commented Feb 1, 2024

Sorry, I just clicked update on your PR thinking I was on mine!

This should auto-instrument Koa performance. We still needs tests for this at some point.
@mydea mydea force-pushed the fn/add-koa-integration branch from 9730e54 to 3fbfd76 Compare February 2, 2024 10:17
@mydea mydea merged commit 649101d into develop Feb 2, 2024
121 checks passed
@mydea mydea deleted the fn/add-koa-integration branch February 2, 2024 10:56
onurtemizkan pushed a commit that referenced this pull request Feb 4, 2024
This should auto-instrument Koa performance. We still needs tests for
this at some point. cc @timfish / @onurtemizkan

The main reason to add this is that we have docs for this on
docs.sentry.com, and we need a way to properly replace/update them (and
they currently rely a lot on `startTransaction()` etc.) With this we can
eventually just update this to use the default koa integration we
provide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants