-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(browser): Don't use chrome variable name #10874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
mydea and
s1gr1d
and removed request for
a team
February 29, 2024 20:48
size-limit report 📦
|
Closed
3 tasks
lforst
approved these changes
Mar 1, 2024
mydea
approved these changes
Mar 1, 2024
Closed
AbhiPrasad
added a commit
that referenced
this pull request
Mar 7, 2024
resolves #6880 Using `const chrome = ...` or similar breaks certain setups based on their bundler config. This makes changes to browser code so that we never declare a variable named `chrome`. I tried setting up https://eslint.org/docs/latest/rules/id-denylist to enforce this, but this unfortunately also looks as types declarations (so `type K = { chrome: ... }` is problematic.
This was referenced Mar 12, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6880
Using
const chrome = ...
or similar breaks certain setups based on their bundler config. This makes changes to browser code so that we never declare a variable namedchrome
.I tried setting up https://eslint.org/docs/latest/rules/id-denylist to enforce this, but this unfortunately also looks as types declarations (so
type K = { chrome: ... }
is problematic.