Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(angular): Don't include BrowserApiErrors in bundle #11294

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

AbhiPrasad
Copy link
Member

ref #9508

The BrowserApiErrors integration interfers with Angular error handler, so don't include it in the default integrations.

@AbhiPrasad AbhiPrasad requested review from Lms24 and s1gr1d March 26, 2024 20:15
@AbhiPrasad AbhiPrasad self-assigned this Mar 26, 2024
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 26, 2024
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: Can we add a comment next to getDefaultIntegrations in browser to remember to update the list in angular as well, when it is changed? To ensure we don't forget to keep these in sync?

@AbhiPrasad AbhiPrasad force-pushed the abhi-angular-try-catch-develop branch from 6add689 to 606c389 Compare March 27, 2024 13:35
@AbhiPrasad
Copy link
Member Author

m: Can we add a comment next to getDefaultIntegrations in browser to remember to update the list in angular as well, when it is changed? To ensure we don't forget to keep these in sync?

Great idea!! done with 606c389

Copy link

codecov bot commented Mar 27, 2024

Bundle Report

Changes will increase total bundle size by 2.57kB ⬆️

Bundle name Size Change
@sentry/types-cjs 35 bytes 0 bytes
@sentry-internal/integration-shims-cjs 3.65kB 0 bytes
@sentry/types-esm 35 bytes 0 bytes
@sentry/node-experimental-cjs 157.11kB 0 bytes
@sentry-internal/replay-cjs 306.18kB 0 bytes
@sentry-internal/tracing-esm 107.23kB 8 bytes ⬆️
@sentry-internal/replay-esm 306.29kB 0 bytes
@sentry/vercel-edge-cjs 18.23kB 0 bytes
@sentry/node-experimental-esm 150.43kB 0 bytes
@sentry/aws-serverless-cjs 14.62kB 0 bytes
@sentry-internal/integration-shims-esm 2.99kB 0 bytes
@sentry/utils-cjs 179.0kB 0 bytes
@sentry/node-cjs 337.26kB 0 bytes
@sentry-internal/replay-canvas-esm 29.34kB 0 bytes
@sentry-internal/replay-canvas-cjs 29.43kB 0 bytes
@sentry/bun-cjs 13.5kB 0 bytes
@sentry/browser-cjs 107.32kB 166 bytes ⬆️
@sentry-internal/node-integration-tests-cjs 1.04kB 0 bytes
@sentry/utils-esm 174.41kB 0 bytes
@sentry/browser-esm 104.51kB 166 bytes ⬆️
@sentry-internal/feedback-cjs 65.56kB 0 bytes
@sentry/astro-cjs 27.13kB 0 bytes
@sentry/svelte-esm 12.72kB 0 bytes
@sentry-internal/node-integration-tests-esm 888 bytes 0 bytes
@sentry/google-cloud-serverless-esm 19.16kB 0 bytes
@sentry/core-cjs 240.68kB 1.4kB ⬇️
@sentry/svelte-cjs 13.84kB 0 bytes
@sentry/node-esm 333.86kB 0 bytes
@sentry/astro-esm 23.39kB 0 bytes
@sentry/wasm-cjs 5.2kB 0 bytes
@sentry/bun-esm 10.05kB 0 bytes
@sentry/gatsby-cjs 905 bytes 0 bytes
@sentry/core-esm 237.11kB 1.4kB ⬇️
@sentry/vue-cjs 20.19kB 0 bytes
@sentry/google-cloud-serverless-cjs 23.0kB 0 bytes
@sentry/remix-esm 48.23kB 0 bytes
@sentry/sveltekit-esm 61.08kB 0 bytes
@sentry/react-cjs 45.04kB 0 bytes
@sentry/gatsby-esm 385 bytes 0 bytes
@sentry/sveltekit-cjs 69.31kB 0 bytes
@sentry/remix-cjs 53.62kB 0 bytes
@sentry/wasm-esm 4.85kB 0 bytes
@sentry/nextjs-esm 20.02kB 0 bytes
@sentry/nextjs-cjs 20.52kB 5.02kB ⬆️
@sentry/react-esm 41.18kB 0 bytes
@sentry/profiling-node-cjs 25.5kB 0 bytes
@sentry/profiling-node-esm 25.52kB 0 bytes
@sentry/vue-esm 18.85kB 0 bytes
@sentry/vercel-edge-esm 16.13kB 0 bytes
@sentry/opentelemetry-cjs 71.63kB 0 bytes
@sentry-internal/tracing-cjs 107.97kB 8 bytes ⬆️
@sentry-internal/feedback-esm 65.28kB 0 bytes
@sentry/opentelemetry-esm 70.52kB 0 bytes

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.46 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay) 71.8 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.6 KB (-0.11% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.35 KB (-0.14% 🔽)
@sentry/browser (incl. Tracing) 36.63 KB (-0.23% 🔽)
@sentry/browser (incl. browserTracingIntegration) 36.63 KB (-0.23% 🔽)
@sentry/browser (incl. feedbackIntegration) 31.38 KB (0%)
@sentry/browser (incl. feedbackModalIntegration) 31.5 KB (0%)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.51 KB (0%)
@sentry/browser (incl. sendFeedback) 27.45 KB (0%)
@sentry/browser 22.61 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.9 KB (-0.11% 🔽)
CDN Bundle (incl. Tracing, Replay) 69.72 KB (-0.11% 🔽)
CDN Bundle (incl. Tracing) 36.26 KB (-0.25% 🔽)
CDN Bundle 23.97 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.89 KB (-0.11% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 109.45 KB (-0.21% 🔽)
CDN Bundle - uncompressed 70.94 KB (0%)
@sentry/react (incl. Tracing, Replay) 71.78 KB (-0.12% 🔽)
@sentry/react 22.64 KB (0%)

@AbhiPrasad AbhiPrasad merged commit df68e99 into develop Mar 27, 2024
88 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-angular-try-catch-develop branch March 27, 2024 14:11
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
ref getsentry#9508

The `BrowserApiErrors` integration interfers with Angular error handler,
so don't include it in the default integrations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants