Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): [v7] Skip capturing Hapi Boom error responses #11324

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix(node): [v7] Skip capturing Hapi Boom error responses #11324

merged 2 commits into from
Mar 28, 2024

Conversation

AbhiPrasad
Copy link
Member

Backport of #11151 to v7

@AbhiPrasad AbhiPrasad requested a review from onurtemizkan March 27, 2024 17:49
@AbhiPrasad AbhiPrasad changed the title fix(node): Skip capturing Hapi Boom error responses. (#11151) fix(node): [v7] Skip capturing Hapi Boom error responses Mar 27, 2024
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 27, 2024
Closed
@onurtemizkan @AbhiPrasad
fix(node): Skip capturing Hapi Boom error responses. (#11151)
4dad740 
Resolves: #11069

After checking the behaviour, it seems to me that we don't need to
capture any Boom responses, as the errors that may cause a `5xx`
response are already captured by the core logic. To add an option to
control this behaviour, we need to update the usage of
`hapiErrorPlugin`, converting it to a function signature, which IMO may
not worth doing, as I'm not sure if users in general would need to use
it.

This also adds `expectError()` to the `node-integration-tests` runner to
allow `5xx` responses to be tested.
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.48 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.47 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.49 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.11 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.41 KB (+0.02% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.29 KB (+0.01% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.52 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.53 KB (0%)
@sentry/browser - Webpack (gzipped) 22.74 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.59 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.97 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.77 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.31 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.12 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 71.97 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 22.77 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.81 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.95 KB (+0.01% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.3 KB (0%)

@AbhiPrasad AbhiPrasad mentioned this pull request Mar 28, 2024
Merged
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 28, 2024 17:52
@AbhiPrasad AbhiPrasad merged commit 1c43a5a into v7 Mar 28, 2024
81 checks passed
@AbhiPrasad AbhiPrasad deleted the v7-abhi-hapi-boom branch March 28, 2024 17:56
AbhiPrasad added a commit that referenced this pull request Mar 28, 2024
@AbhiPrasad
meta: CHANGELOG for 7.109.0 (#11340)
5c04c02 
Dependent on #11324

tracking issue:
#11247
@Lms24 Lms24 mentioned this pull request Apr 10, 2024
Merged
@Lms24 Lms24 mentioned this pull request May 31, 2024
Merged
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Merged
This was referenced Jun 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@onurtemizkan onurtemizkan Awaiting requested review from onurtemizkan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @mydea @onurtemizkan