feat(nestjs): Add @sentry/nestjs
#12613
Conversation
packages/nestjs/src/sdk.ts
Outdated
| /** | ||
| * Initializes the NestJS SDK | ||
| */ | ||
| export function init(options: NodeOptions | undefined = {}): void { |
There was a problem hiding this comment.
h: SDKs are supposed to return the Client
packages/nestjs/README.md
Outdated
| </a> | ||
| </p> | ||
|
|
||
| # Official Sentry SDK for NestJS |
There was a problem hiding this comment.
| # Official Sentry SDK for NestJS | |
| # Official Sentry SDK for NestJS (EXPERIMENTAL) |
There was a problem hiding this comment.
updated the readme to indicate that it is experimental
There was a problem hiding this comment.
I would still put the change Andrei suggested. It's better to be very loud with it than people potentially breaking because they missed it.
There was a problem hiding this comment.
Yea, the Nuxt and the Solid sdk both follow this "convention" now.
packages/nestjs/jest.config.js
Outdated
| @@ -0,0 +1 @@ | |||
| module.exports = require('../../jest/jest.config.js'); | |||
There was a problem hiding this comment.
Yeah I like that. @nicohrubec would you mind adding a vitest setup instead of jest. You can take inspiration from the svelte, sveltekit and solid packages.
packages/nestjs/yarn.lock
Outdated
| @@ -0,0 +1,772 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
m: You can remove this file, it was probably generated before you added the package to the workspace.
There was a problem hiding this comment.
thanks for the hint, removed it
packages/nestjs/package.json
Outdated
| "optionalDependencies": { | ||
| "opentelemetry-instrumentation-fetch-node": "1.2.0" | ||
| }, |
| # Official Sentry SDK for NestJS | ||
|
|
||
| This SDK is considered **experimental and in an alpha state**. It may experience breaking changes. Please reach out on | ||
| [GitHub](https://github.com/getsentry/sentry-javascript/issues/new/choose) if you have any feedback or concerns. |
There was a problem hiding this comment.
I think we should flesh out the readme a bit more. Ideally we get it to a similar state as the readme of the @sentry/node package with basic setup instructions and how to use. Once we add more features to this package we can update this readme again.
lforst
dismissed
andreiborza’s stale review
dismissing because some critical things are still missing
This reverts commit 7c38b7f.
packages/nestjs/package.json
Outdated
| @@ -0,0 +1,71 @@ | |||
| { | |||
| "name": "@sentry/nestjs", | |||
| "version": "8.11.0", | |||
There was a problem hiding this comment.
This should be 8.12.0 now right?
packages/nestjs/package.json
Outdated
| "author": "Sentry", | ||
| "license": "MIT", | ||
| "engines": { | ||
| "node": ">=14.18" |
There was a problem hiding this comment.
We should align this with the minimum supported version of nest since we also don't test for 14.
Implements basic nest js package as wrapper on top of nest js
From my sample app:
