Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deno): Add prepack for deno build #12700

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

AbhiPrasad
Copy link
Member

fixes #12698

Adds back prepack script just for deno which was removed in #12656 because it's a breaking change for the deno package which relies on the directory structure for their import path.

@AbhiPrasad AbhiPrasad requested a review from mydea June 28, 2024 16:29
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we actually put a minimal prepack script in here, that does not have all the variables etc. but really does only the things we specifically need for deno? Otherwise it will be harder in the future to understand what of this is actually needed for deno to work etc.?

FWIW I'm also OK with merging this as-is and streamlining it in a follow up, if we want to get this out ASAP.

@AbhiPrasad AbhiPrasad force-pushed the abhi-fix-deno-output branch from 81c823b to 17c1a4d Compare July 2, 2024 14:08
@AbhiPrasad
Copy link
Member Author

Could we actually put a minimal prepack script in here, that does not have all the variables etc. but really does only the things we specifically need for deno? Otherwise it will be harder in the future to understand what of this is actually needed for deno to work etc.?

Done with 17c1a4d - also experimented with jsdoc types (because I didn't want to refactor the require calls), so was an interesting experiment overall.

@AbhiPrasad AbhiPrasad requested a review from mydea July 2, 2024 14:09
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🚀

@AbhiPrasad AbhiPrasad merged commit 840dd8f into develop Jul 2, 2024
83 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-fix-deno-output branch July 2, 2024 14:28
mydea pushed a commit that referenced this pull request Jul 5, 2024
In #12700 I adjusted
the prepack script to bring back the build directory, but I forgot to
adjust `npm pack X` to make sure we pack the tarball from the `build`
directory. This patch fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Deno release 8.13.0 broke imports / has incorrect import details in README
2 participants