Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Add request parameter to httpIntegration ignore callbacks #12930

Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 16, 2024

This PR adds a second parameter (request) to the httpIntegration's ignoreIncomingRequests and ignoreOutgoingRequests callbacks. This allows users to not only filter on the URL as previously but on the entire request objects.

Docs PR: getsentry/sentry-docs#10735

ref #12913

@Lms24 Lms24 changed the base branch from develop to lms/fix-node-http-ignoreIncomingRequests-url July 16, 2024 10:31
@Lms24 Lms24 marked this pull request as draft July 16, 2024 10:38
@Lms24 Lms24 self-assigned this Jul 16, 2024
@Lms24 Lms24 force-pushed the lms/feat-node-http-add-request-param-to-ignore-callbacks branch from 4c5288e to 6d4c859 Compare July 16, 2024 11:11
Copy link
Member Author

@Lms24 Lms24 Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file look more drastic than they are. I just grouped the two tests (1 existed previously, 1 added new) per ignore hook under a describe block causing the large diff.

Copy link
Contributor

github-actions bot commented Jul 16, 2024

size-limit report 📦

Path Size
@sentry/browser 22.3 KB (0%)
@sentry/browser (incl. Tracing) 33.69 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.78 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.08 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.17 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 86.49 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 88.37 KB (0%)
@sentry/browser (incl. metrics) 26.59 KB (0%)
@sentry/browser (incl. Feedback) 38.98 KB (0%)
@sentry/browser (incl. sendFeedback) 26.92 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.54 KB (0%)
@sentry/react 25.07 KB (0%)
@sentry/react (incl. Tracing) 36.75 KB (0%)
@sentry/vue 26.41 KB (0%)
@sentry/vue (incl. Tracing) 35.57 KB (0%)
@sentry/svelte 22.44 KB (0%)
CDN Bundle 23.52 KB (0%)
CDN Bundle (incl. Tracing) 35.47 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.87 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.14 KB (0%)
CDN Bundle - uncompressed 69 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 104.93 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 216.71 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 229.43 KB (0%)
@sentry/nextjs (client) 36.62 KB (0%)
@sentry/sveltekit (client) 34.34 KB (0%)
@sentry/node 130.83 KB (0%)
@sentry/node - without tracing 91.91 KB (0%)
@sentry/aws-serverless 117.08 KB (0%)

Base automatically changed from lms/fix-node-http-ignoreIncomingRequests-url to develop July 16, 2024 11:56
@Lms24 Lms24 force-pushed the lms/feat-node-http-add-request-param-to-ignore-callbacks branch from 6d4c859 to 67f4e32 Compare July 16, 2024 13:08
@Lms24 Lms24 marked this pull request as ready for review July 16, 2024 13:49
@Lms24 Lms24 merged commit 8b24731 into develop Jul 16, 2024
105 checks passed
@Lms24 Lms24 deleted the lms/feat-node-http-add-request-param-to-ignore-callbacks branch July 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants