Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport(tracing): Report dropped spans for transactions #13343

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Aug 13, 2024

mydea and others added 2 commits August 13, 2024 11:20
#13022)

Fixes #12849.

This is a bit tricky because `beforeSendTransaction` can return a
promise, so in order to avoid dealing with this I put the # of spans on
the sdk metadata, and then compare that afterwards.
@krystofwoldrich krystofwoldrich requested a review from mydea August 13, 2024 09:24
Copy link
Contributor

github-actions bot commented Aug 13, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.89 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 76.14 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.52 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.77 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.66 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.72 KB (added)
@sentry/browser - Webpack (gzipped) 22.91 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 79.17 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.49 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.41 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.92 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 109.52 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 76.24 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.45 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.4 KB (added)
@sentry/react - Webpack (gzipped) 22.94 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped) 54.27 KB (added)
@sentry-internal/feedback - Webpack (gzipped) 17.34 KB (added)

@krystofwoldrich krystofwoldrich merged commit f54c97a into v7 Aug 13, 2024
104 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/backport-dropped-spans branch August 13, 2024 12:06
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Aug 14, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`7.118.0` -> `7.119.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/7.118.0/7.119.0) |
| [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.25.0` -> `8.26.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.25.0/8.26.0) |

---

### Release Notes

<details>
<summary>getsentry/sentry-javascript (@&#8203;sentry/node)</summary>

### [`v7.119.0`](https://github.com/getsentry/sentry-javascript/releases/tag/7.119.0)

[Compare Source](getsentry/sentry-javascript@7.118.0...7.119.0)

-   backport(tracing): Report dropped spans for transactions ([#&#8203;13343](getsentry/sentry-javascript#13343))

#### Bundle size 📦

| Path                                                                               | Size              |
| ---------------------------------------------------------------------------------- | ----------------- |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) - Webpack (gzipped)              | 80.96 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - Webpack (gzipped)                        | 71.89 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) - Webpack (gzipped)            | 76.14 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) | 65.52 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing) - Webpack (gzipped)                                | 35.77 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. browserTracingIntegration) - Webpack (gzipped)              | 35.66 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Feedback) - Webpack (gzipped)                               | 31.71 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) - Webpack (gzipped)                           | 31.72 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) - Webpack (gzipped)                                                | 22.91 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)       | 79.17 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)                 | 70.49 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing) - ES6 CDN Bundle (gzipped)                         | 36.17 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) - ES6 CDN Bundle (gzipped)                                         | 25.41 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) | 221.92 KB |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)         | 109.52 KB |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) - ES6 CDN Bundle (minified & uncompressed)                         | 76.24 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing) - ES5 CDN Bundle (gzipped)                         | 39.45 KB  |
| [@&#8203;sentry/react](https://github.com/sentry/react) (incl. Tracing, Replay) - Webpack (gzipped)                          | 72.4 KB   |
| [@&#8203;sentry/react](https://github.com/sentry/react) - Webpack (gzipped)                                                  | 22.94 KB  |
| [@&#8203;sentry/nextjs](https://github.com/sentry/nextjs) Client (incl. Tracing, Replay) - Webpack (gzipped)                  | 90.16 KB  |
| [@&#8203;sentry/nextjs](https://github.com/sentry/nextjs) Client - Webpack (gzipped)                                          | 54.27 KB  |
| [@&#8203;sentry-internal/feedback](https://github.com/sentry-internal/feedback) - Webpack (gzipped)                                      | 17.34 KB  |

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - "after 23:30 every weekday,before 6:00 every weekday,before 7:00 every weekend" in timezone Europe/Paris.

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNy4wIiwidXBkYXRlZEluVmVyIjoiMzguMjguMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/18
Reviewed-by: Alexandre Soro <code@soro.dev>
Co-authored-by: renovate <renovate@git.tristess.app>
Co-committed-by: renovate <renovate@git.tristess.app>
vjousse pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Oct 1, 2024
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)


<h3>Snyk has created this PR to upgrade @sentry/tracing from 7.114.0 to
7.119.0.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.

<hr/>


- The recommended version is **5 versions** ahead of your current
version.

- The recommended version was released on **a month ago**.



<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>@sentry/tracing</b></summary>
    <ul>
      <li>
<b>7.119.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/7.119.0">2024-08-14</a></br><ul>
<li>backport(tracing): Report dropped spans for transactions (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2462852751" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13343"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13343/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13343">#13343</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay, Feedback) - Webpack
(gzipped)</td>
<td>80.96 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>71.89 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay with Canvas) - Webpack
(gzipped)</td>
<td>76.14 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>65.52 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>35.77 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. browserTracingIntegration) - Webpack
(gzipped)</td>
<td>35.66 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Feedback) - Webpack (gzipped)</td>
<td>31.71 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. sendFeedback) - Webpack (gzipped)</td>
<td>31.72 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>22.91 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle
(gzipped)</td>
<td>79.17 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>70.49 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>36.17 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>25.41 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>221.92 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>109.52 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>76.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>39.45 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>72.4 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>22.94 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>90.16 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>54.27 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>17.34 KB</td>
</tr>
</tbody>
</table>
      </li>
      <li>
        <b>7.118.0</b> - 2024-06-21
      </li>
      <li>
        <b>7.117.0</b> - 2024-06-10
      </li>
      <li>
        <b>7.116.0</b> - 2024-05-17
      </li>
      <li>
        <b>7.115.0</b> - 2024-05-16
      </li>
      <li>
        <b>7.114.0</b> - 2024-05-08
      </li>
    </ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/tracing
GitHub release notes</a>
  </details>
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.

---

**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._

**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIyYTM5NGMwOC0xYTczLTQ0OTEtODFkOS0wMzRiMmMyYjU5YjQiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjJhMzk0YzA4LTFhNzMtNDQ5MS04MWQ5LTAzNGIyYzJiNTliNCJ9fQ=="
width="0" height="0"/>

> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/tracing&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/tracing","from":"7.114.0","to":"7.119.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"2a394c08-1a73-4491-81d9-034b2c2b59b4","prPublicId":"2a394c08-1a73-4491-81d9-034b2c2b59b4","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":5,"publishedDate":"2024-08-14T10:19:27.627Z"},"vulns":[]}'

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@Maliksb11
Copy link

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants