Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): Fixes potential out-of-order segments #13609

Merged
merged 1 commit into from
Sep 10, 2024

Commits on Sep 6, 2024

  1. fix(replay): Fixes potential issue with too many flushes

    This fixes a potential issue where our flush "lock" was not being respected in two cases:
    
    1) No current flush in progress, but flush throws an error (this should be rare as the common errors that get thrown should stop the replay completely)
    2) Flush is in progress, which skips the code block that releases lock and then calls debouncedFlush. This leaves the lock always set to a resolved (or rejected) promise.
    
    This ultimately should not change too much as the flush calls are debounced anyway, but this cleans up the code a bit and also logs any exceptions that may occur.
    billyvg committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    055861b View commit details
    Browse the repository at this point in the history