Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profiler): scope require to binding import call #13834

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

fix(profiler): scope require to binding import call #13834

wants to merge 18 commits into from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Sep 30, 2024

Dont override global require, as it causes issues with our esm/cjs runtime detection and instead scope it to binding import call

Fixes: #13662

@JonasBa JonasBa requested a review from AbhiPrasad September 30, 2024 16:32
@JonasBa JonasBa mentioned this pull request Sep 30, 2024
Open
3 tasks
AbhiPrasad
AbhiPrasad reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a regression test

@JonasBa JonasBa force-pushed the jb/profiling/requrie branch from 42e2a5b to a92ae7e Compare October 2, 2024 13:59
@JonasBa
Copy link
Member Author

JonasBa commented Oct 2, 2024 •
edited
Loading

This needs a regression test

I'm going to do some testing first to see if this is even true, opened it thinking we have tests for isCJS and it would fail or pass, but doesn't look like we do.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.73 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 35.12 KB - -
@sentry/browser (incl. Tracing, Replay) 71.86 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.26 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.21 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.82 KB - -
@sentry/browser (incl. metrics) 27 KB - -
@sentry/browser (incl. Feedback) 39.87 KB - -
@sentry/browser (incl. sendFeedback) 27.38 KB - -
@sentry/browser (incl. FeedbackAsync) 32.17 KB - -
@sentry/react 25.49 KB - -
@sentry/react (incl. Tracing) 38.09 KB - -
@sentry/vue 26.91 KB - -
@sentry/vue (incl. Tracing) 37.02 KB - -
@sentry/svelte 22.87 KB - -
CDN Bundle 24.11 KB - -
CDN Bundle (incl. Tracing) 36.96 KB - -
CDN Bundle (incl. Tracing, Replay) 71.65 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.99 KB - -
CDN Bundle - uncompressed 70.7 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.73 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.24 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.46 KB - -
@sentry/nextjs (client) 38.06 KB - -
@sentry/sveltekit (client) 35.74 KB - -
@sentry/node 125.15 KB - -
@sentry/node - without tracing 94.25 KB - -
@sentry/aws-serverless 103.81 KB - -

View base workflow run

@JonasBa JonasBa force-pushed the jb/profiling/requrie branch from b80980e to 2a49051 Compare October 4, 2024 16:09
@JonasBa
Copy link
Member Author

JonasBa commented Oct 7, 2024

This breaks bundlers 😭

@Lms24 Lms24 mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fastify is not instrumented in combination with node profiling and tracesSampleRate
2 participants
@JonasBa @AbhiPrasad