ref: Disable incoming HTTP request instrumentation #13918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
approved these changes
Oct 9, 2024
| @@ -56,7 +56,7 @@ test('Should record exceptions and transactions for faulty route handlers', asyn | |||
|
|
|||
| expect(routehandlerTransaction.contexts?.trace?.status).toBe('internal_error'); | |||
| expect(routehandlerTransaction.contexts?.trace?.op).toBe('http.server'); | |||
| expect(routehandlerTransaction.contexts?.trace?.origin).toContain('auto.http.otel.http'); | |||
| expect(routehandlerTransaction.contexts?.trace?.origin).toContain('auto'); | |||
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
12 tasks
lforst
commented
Oct 9, 2024
| } | ||
| } | ||
|
|
||
| // Next.js 13 is not correctly picking up tracing data for trace propagation so we use a back-fill strategy |
There was a problem hiding this comment.
This is the worst thing I have done all week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the instrumentation for incoming HTTP requests to be consistent across Next.js versions for instrumentation.
Next 13 and 15 work with the HTTP instrumentation. 14 doesn't.