Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Skip optional E2E tests on release branches #14424

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 22, 2024

Optional tests should not block releases.

There are two groups of optional tests:

  1. Canary type tests
  2. Tests that send data to sentry

IMHO both of these can be skipped on release branches, as failure in either of them should not affect the release. They will (for now) still run on develop, we can revisit this if we want.

@mydea mydea requested review from lforst, Lms24 and chargome November 22, 2024 07:48
@mydea mydea self-assigned this Nov 22, 2024
@mydea mydea merged commit 90f958f into develop Nov 22, 2024
66 checks passed
@mydea mydea deleted the fn/skip-optional-tests-release branch November 22, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants