Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-serverless): Remove v8 layer as it overwrites the current layer for docs #14679

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix(aws-serverless): Remove v8 layer as it overwrites the current layer for docs #14679

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05a5a96
fix(aws-serverless): Remove v8 layer as it overwrites the current lay…
andreiborza Dec 12, 2024
6d83b44
Move v8 layer up so current layer becomes latest
andreiborza Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .craft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,12 @@ targets:
id: '@sentry-internal/eslint-config-sdk'
includeNames: /^sentry-internal-eslint-config-sdk-\d.*\.tgz$/

# AWS Lambda Layer target
# TODO(v9): Remove this target
# NOTE: We publish the v8 layer under its own name so people on v8 can still get patches
# whenever we release a new v8 version—otherwise we would overwrite the current major lambda layer.
- name: aws-lambda-layer
includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/
layerName: SentryNodeServerlessSDK
layerName: SentryNodeServerlessSDKv8
compatibleRuntimes:
- name: node
versions:
Expand All @@ -157,13 +159,10 @@ targets:
- nodejs20.x
license: MIT

# NOTE: We publish the v8 layer under its own name so people on v8 can still get patches
# whenever we release a new v8 version—otherwise we would overwrite the current major lambda layer.

# AWS Lambda Layer target
- name: aws-lambda-layer
includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/
layerName: SentryNodeServerlessSDKv8
layerName: SentryNodeServerlessSDK
compatibleRuntimes:
- name: node
versions:
Expand Down
Loading