Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react)!: Remove deprecated getNumberOfUrlSegments method #14744

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

AbhiPrasad
Copy link
Member

Removes code deprecated in #14458

Removes getNumberOfUrlSegments as a public export from @sentry/core.

This method is still used, so we extract it into a helper in @sentry/react (and port the tests accordingly).

@AbhiPrasad AbhiPrasad requested a review from a team December 16, 2024 21:58
@AbhiPrasad AbhiPrasad self-assigned this Dec 16, 2024
@AbhiPrasad AbhiPrasad requested review from mydea and andreiborza and removed request for a team December 16, 2024 21:58
@AbhiPrasad AbhiPrasad added this to the 9.0.0 milestone Dec 17, 2024
@AbhiPrasad AbhiPrasad force-pushed the abhi-getNumberOfUrlSegments branch from 2399516 to 9758b51 Compare December 17, 2024 15:12
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 17, 2024 15:12
@AbhiPrasad AbhiPrasad merged commit 987bff8 into develop Dec 17, 2024
156 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-getNumberOfUrlSegments branch December 17, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants