Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MetricsInstrumentation): check document.scripts not null #3707

Closed
wants to merge 1 commit into from
Closed

fix(MetricsInstrumentation): check document.scripts not null #3707

wants to merge 1 commit into from

Conversation

janpoem
Copy link

@janpoem janpoem commented Jun 18, 2021

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

fix #3705

@janpoem janpoem requested a review from kamilogorek as a code owner June 18, 2021 09:58
@AbhiPrasad AbhiPrasad self-requested a review June 18, 2021 11:03
AbhiPrasad
AbhiPrasad approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. You can fix the lint error by adding a eslint disable ahead of the addPerformanceEntries function.

// eslint-disable-next-line complexity
public addPerformanceEntries(transaction: Transaction): void {

AbhiPrasad added a commit that referenced this pull request Jun 29, 2021
@AbhiPrasad
fix(tracing): Add check for document.scripts in metrics
65a1490 
Fixes #3705

Supersedes #3707

We should check if document.scripts exists as it does not exist in some
browser environments. This patch also refectors the document logic
to rely on `global.document` instead of `document`.
AbhiPrasad added a commit that referenced this pull request Jun 29, 2021
@AbhiPrasad
fix(tracing): Add check for document.scripts in metrics
f89b869 
Fixes #3705

Supersedes #3707

We should check if document.scripts exists as it does not exist in some
browser environments. This patch also refactors the document logic
to rely on `global.document` instead of `document`.
@AbhiPrasad AbhiPrasad mentioned this pull request Jun 29, 2021
Merged
@AbhiPrasad
Copy link
Member

Closing this PR in favour of #3766. Thank you for your contribution!

@AbhiPrasad AbhiPrasad closed this Jun 29, 2021
AbhiPrasad added a commit that referenced this pull request Jun 30, 2021
@AbhiPrasad
fix(tracing): Add check for document.scripts in metrics (#3766)
5289d40 
Fixes #3705

Supersedes #3707

We should check if document.scripts exists as it does not exist in some
browser environments. This patch also refactors the document logic
to rely on `global.document` instead of `document`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There are not 'document.scripts' in mini-program environment
2 participants
@janpoem @AbhiPrasad