ref(utils): Remove getGlobalObject()
usage from @sentry/utils
#5831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5821 ended up being a rather huge PR so this is the first of many PRs that makes these changes per package. For now we keep the
getGlobalObject()
implementation until all the packages are migrated.As discussed here, this PR:
getGlobalObject
with a constGLOBAL_OBJ
which retains the runtime detection from feat(utils): Modern implementation ofgetGlobalObject
#5809GLOBAL_OBJ
is always accessedWINDOW
const which returnsGLOBAL_OBJ
but withtypeof GLOBAL_OBJ & Window
type.@sentry/browser
to ensure stricter typing around the global objectWINDOW_GLOBAL
to remove any ambiguity?