Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add name to Span #8949

Merged
merged 1 commit into from
Sep 6, 2023
Merged

feat(core): Add name to Span #8949

merged 1 commit into from
Sep 6, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 5, 2023

In order to align Span & Transaction for usage in new performance APIs, this add name to the Span that also always returns a string.

In order to align `Span` & `Transaction` for usage in new performance APIs, this add `name` to the `Span` that also always returns a string.
@mydea mydea requested a review from AbhiPrasad September 5, 2023 13:21
@mydea mydea self-assigned this Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.35 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.24 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped) 21.84 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.87 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.18 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.18 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.81 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.09 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.73 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.08 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.37 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped) 21.88 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.23 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.81 KB (+0.03% 🔺)

@mydea mydea merged commit 6643671 into develop Sep 6, 2023
@mydea mydea deleted the fn/span-name-getter branch September 6, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants