Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(integrations): Refactor pluggable integrations to use processEvent #9021

Merged
merged 1 commit into from
Oct 3, 2023
Merged

ref(integrations): Refactor pluggable integrations to use processEvent #9021

merged 1 commit into from
Oct 3, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 13, 2023 •
edited
Loading

This refactors pluggable integrations to use processEvent.

@mydea mydea self-assigned this Sep 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 84.26 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.4 KB (0%)
@sentry/browser - Webpack (gzipped) 22 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 78.68 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.5 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.59 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 254.1 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.38 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.23 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.38 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.27 KB (0%)
@sentry/react - Webpack (gzipped) 22.03 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.18 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.93 KB (-0.04% 🔽)

@mydea mydea force-pushed the fn/integration-processEvent branch from c2d603d to c354494 Compare September 14, 2023 14:42
Base automatically changed from fn/integration-processEvent to develop September 15, 2023 08:07
@mydea mydea force-pushed the fn/integrations-integrations branch 2 times, most recently from 3159fdb to 09b53e6 Compare September 21, 2023 07:26
@mydea mydea force-pushed the fn/integrations-integrations branch from 09b53e6 to 62b438f Compare September 27, 2023 13:56
@mydea mydea force-pushed the fn/integrations-integrations branch from 62b438f to c9d1e40 Compare September 28, 2023 10:02
@mydea mydea marked this pull request as ready for review September 28, 2023 10:02
@mydea mydea requested a review from AbhiPrasad September 28, 2023 10:02
@mydea mydea merged commit abd8b4d into develop Oct 3, 2023
82 checks passed
@mydea mydea deleted the fn/integrations-integrations branch October 3, 2023 14:22
@krystofwoldrich krystofwoldrich mentioned this pull request Jan 4, 2024
Closed
11 tasks
@krystofwoldrich
Copy link
Member

krystofwoldrich commented Jan 4, 2024 •
edited
Loading

I believe we do not guarantee the order of execution of integrations, but anyway, this changed it. Maybe should have been a breaking change?

@mydea
Copy link
Member Author

mydea commented Jan 5, 2024

In theory in places where the execution is important we should use preprocessEvent to ensure it runs before processEvent. For what integration is this important/problematic here?

@krystofwoldrich krystofwoldrich mentioned this pull request Jan 22, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @krystofwoldrich @AbhiPrasad