fix(core): Ensure global event processors are always applied to event #9064
Conversation
Even if no scope is passed.
| @@ -15,7 +15,7 @@ for (const dir of scenariosDirs) { | |||
|
|
|||
| const processes = scenarios.map(([filename, filepath]) => { | |||
| return new Promise(resolve => { | |||
| const scenarioProcess = spawn('node', [filepath]); | |||
| const scenarioProcess = spawn('node', [filepath], { timeout: 10000 }); | |||
There was a problem hiding this comment.
Adding a timeout so this does not run forever, if a failure happens.
| @@ -12,6 +12,9 @@ function cleanUpAndExitSuccessfully() { | |||
| } | |||
|
|
|||
| function assertSessionAggregates(session, expected) { | |||
| if (!session.aggregates) { | |||
There was a problem hiding this comment.
this already failed before, but did not result in test failures because apparently some global event processors were not running and thus no sentry error was produced for this (?)
size-limit report 📦
|
This happens e.g. if you call |
Even if no scope is passed.
I guess this is kind of behavior changing, but I'd argue it is just fixing an unexpected behaviour that's not actually intuitive/logical - that global event processors are only applied if a scope is provided.
I extracted this out from #9032, as I figured this is actually a reasonable change on it's own, so it's easier to reason about this in it's own PR.