Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Rate limit local variables for caught exceptions and enable captureAllExceptions by default #9102

Merged
merged 9 commits into from
Sep 28, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Sep 25, 2023

This PR:

  • Adds a rate limiter that disables capturing caught exceptions when the exceptions per second limit is reached
    • Initially waits 5 seconds before re-enabling caught capturing
    • Doubles the backoff wait time every time rate limiting is re-triggered
    • The backoff time is never reset so if it keeps being triggered, it will remain disabled
  • Enables captureAllExceptions by default (50 exceptions per second)

@timfish timfish changed the title feat(node): Add rate limiting to uncaught exception capturing and enable by default feat(node): Add rate limiting for capturing local variables for caught exceptions and enable by default Sep 26, 2023
@timfish timfish changed the title feat(node): Add rate limiting for capturing local variables for caught exceptions and enable by default feat(node): Rate limit local variables for caught exceptions and enable captureAllExceptions by default Sep 26, 2023
@timfish timfish requested a review from AbhiPrasad September 28, 2023 12:30
@AbhiPrasad AbhiPrasad merged commit aa41f97 into getsentry:develop Sep 28, 2023
49 checks passed
@timfish timfish deleted the feat/local-variables-rate-limit branch September 28, 2023 15:02
@timfish
Copy link
Collaborator Author

timfish commented Sep 28, 2023

Need to update the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants