fix(nextjs): Filter RequestAsyncStorage locations by locations that webpack will resolve
#9114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… webpack will resolve
size-limit report 📦
|
lforst
changed the title
RequestAsyncStorage locations by locations that webpack will resolve
mydea
approved these changes
Sep 26, 2023
@mydea Story of my life |
lforst
deleted the
lforst-filter-request-async-storage-location-by-webpack-resolvable-locations
branch
billyvg
pushed a commit
that referenced
this pull request
Sep 26, 2023
… webpack will resolve (#9114)
c298lee
pushed a commit
that referenced
this pull request
Sep 27, 2023
… webpack will resolve (#9114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9092
In our previous attempt of fixing we used
require.resolves'pathsoption which we wanted to limit the locations with to check for the availability of Next.jsRequestAsyncStoragemodule.Unfortunately,
require.resolvewill always check "global" node_modules for when resolving, which means that (old) global installations of Next.js would have still been picked up.With this PR we additionally check for whether the resolved path would be within the locations webpack would check for resolving the module. This way we shouldn't pick up any global installations of Next.js.