Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(angular-ivy): Allow Angular 17 in peer dependencies #9386

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Oct 27, 2023

This PR bumps our peer deps to allow for Angular 12-17 in the @sentry/angular-ivy package.

With the improved SSR capabilities and Vite being used for SSR Angular apps during dev mode in Angular 17, there is still an issue with our SDK's package format (APF12) not being compatible with the server-side code. There is a workaround to fix this by only importing our SDK in the client side config but I reached out to the Angular team to find a proper solution.

Given that this bug only exists in SSR Angular apps, I'd argue we can already go ahead and make the peer dep bump.
I tested our SDK in a regular, client-only Angular 17 (RC2) app and errors, performance, replay and source maps seem to work. Angular 17 is scheduled to be released in the week of November 6th.

(Depending on the outcome of angular/angular-cli#26135, we might want to link to the workaround in docs but I'll hold off from doing this just now).

@Lms24 Lms24 requested review from lforst and AbhiPrasad October 27, 2023 09:16
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 77.44 KB (-6.33% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 66.48 KB (-7.39% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.94 KB (0%)
@sentry/browser - Webpack (gzipped) 21.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.66 KB (-7.37% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.93 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.09 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 216.39 KB (-7.47% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 87.77 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.76 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.71 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 77.82 KB (-6.3% 🔽)
@sentry/react - Webpack (gzipped) 21.29 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 94.16 KB (-5.31% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 47.83 KB (0%)

@Lms24 Lms24 merged commit 43ddbbe into develop Oct 27, 2023
47 checks passed
@Lms24 Lms24 deleted the lms/angular-17 branch October 27, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants