Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Hoist RequestData integration to @sentry/core #9597

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 20, 2023

This PR hoists the RequestData integration into @sentry/core and all of its utility functions into @sentry/utils. In the process of this, I ended up merging the two versions of the requestdata.ts utility files we had (one in node and one in utils) to just leave us with the one in utils.

We need to hoist the RequestData integration to be able to use it in different runtime SDKs other than node.

@lforst lforst force-pushed the lforst-hoist-requestdataintegration-to-core branch from 0218ec9 to ce50a60 Compare November 21, 2023 12:58
@lforst lforst marked this pull request as ready for review November 21, 2023 13:33
Copy link
Contributor

github-actions bot commented Nov 22, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.02 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 56.1 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.1 KB (+0.27% 🔺)
@sentry/browser - Webpack (gzipped) 21.41 KB (+0.39% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.42 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.23 KB (+0.29% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.35 KB (+0.35% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 196.93 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.74 KB (+0.35% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.71 KB (+0.49% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.96 KB (+0.3% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.31 KB (+0.12% 🔺)
@sentry/react - Webpack (gzipped) 21.45 KB (+0.39% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.08 KB (+0.11% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.25 KB (+0.18% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.19 KB (+0.55% 🔺)

@lforst lforst merged commit f7257a1 into develop Nov 22, 2023
87 checks passed
@lforst lforst deleted the lforst-hoist-requestdataintegration-to-core branch November 22, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants